This repository was archived by the owner on Jun 24, 2019. It is now read-only.
Travis Jest integtation #7 #30
Open
vittoriodev wants to merge 11 commits intoCoding-Coach:developmentfrom
Open
Travis Jest integtation #7 #30vittoriodev wants to merge 11 commits intoCoding-Coach:developmentfrom
vittoriodev wants to merge 11 commits intoCoding-Coach:developmentfrom
Conversation
added 11 commits
December 18, 2018 02:30
frederikprijck
suggested changes
Jan 7, 2019
| - node_modules | ||
| install: yarn | ||
| script: | ||
| install: npm install |
Contributor
There was a problem hiding this comment.
Why are we using npm instead of yarn here ?
Contributor
It's probably a good idea to focus a PR on one thing instead of combining several changes in a single PR. Makes it easier to review imho. However, if all of the changes made are necessary to fix the tests, tackling travis integration in the same PR isn't really a bad idea I guess. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Travis Jest testing like in issue #7 described.
I fixed the user model (also as preparation for signup) because the jest is failing in current development branch. (E-Mail unique validation problem).
Its my first PR so please be careful with me ;)